Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add JSDoc comments from DefinitelyTyped pull request #203

Conversation

ikelax
Copy link
Contributor

@ikelax ikelax commented Sep 30, 2024

PR Checklist

Overview

The JSDoc comments from the DefinitelyTyped pull request were added. I have found one typo in the comment for strip.ts and fixed it. However, I am not a native English speaker and may have missed something.

💖

@ikelax ikelax changed the title docs: Add JSDoc comments from DefinitelyTyped pull request docs: add JSDoc comments from DefinitelyTyped pull request Sep 30, 2024
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great! ✨

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e13c44a) to head (38151bc).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #203   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          263       303   +40     
  Branches        28        28           
=========================================
+ Hits           263       303   +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9e46292 into omnidan:main Oct 8, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in JSDoc comments from DefinitelyTyped pull request
2 participants