Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

make comment in sitemap optional #8

Open
bnomei opened this issue Sep 7, 2018 · 3 comments
Open

make comment in sitemap optional #8

bnomei opened this issue Sep 7, 2018 · 3 comments

Comments

@bnomei
Copy link

bnomei commented Sep 7, 2018

i get the idea that giving you credit in the sitemap seems reasonable.

<!-- Sitemap generated using https://github.com/omz13/kirby3-xmlsitemap -->

but still i would like you to remove it or make it optional because:

  • i value my clients and their customers security most. none of the code i use gives away directly what cms is used. so attackers do not know which cms was used. the new pages/media paths in thumbs might be a hint. no string reference to kirby whatsoever.
  • your plugin could in theory expose an vulnerability and i would like to hide that as much as possible.
@bnomei
Copy link
Author

bnomei commented Sep 7, 2018

oh its in the xsl as well.

@omz13
Copy link
Owner

omz13 commented Sep 7, 2018

An option to hide is planned.

Also, option to not do the style sheet (because that could be used as an identification vector).

@bvdputte
Copy link

bvdputte commented Oct 1, 2019

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants