You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm honestly not sure if this is documented behavior of the Web Share API but I'm seeing diverging behavior in this instance:
Call navigator.share with the url argument as a /-prefixed path, like /articles/123/
Nativenavigator.share interprets that into <protocol>://<current-domain-and-port>/articles/123/ when passing through to share target. Kind of how the href of an <a> element is understood correctly when it's just /articles/123/.
Polyfill fallback behavior does not do this and just passes through /articles/123/ as the "URL" to any share target.
I'm happy to work on this as a PR to this project but wanted to propose it first and get approval before investing the work.
The text was updated successfully, but these errors were encountered:
josefdlange
changed the title
Absolute path url arguments are not fixed to be at the current page's domain
Absolute path url arguments do not get merged with current domain before passing through to share targets in fallback mode
Nov 12, 2020
It could be done very simplisticly by checking if the first character of url is the forward slash. If it is, then prepend window.location.origin to the given url. That would be consistent with the native Share API.
I think the native Share API throws an error when only the host is given without the protocol, i.e. example.com/articles/123 throws an error whereas https://example.com/articles/123 does not. So the polyfill should ideally throw an error in the case of a host without a protocol.
As you said yourself, I'm also not sure if this is documented behavior. I tested it on the new chromium-based Edge desktop browser. There, the protocol and host are prepended to absolute paths starting with /.
I'm honestly not sure if this is documented behavior of the Web Share API but I'm seeing diverging behavior in this instance:
navigator.share
with theurl
argument as a/
-prefixed path, like/articles/123/
navigator.share
interprets that into<protocol>://<current-domain-and-port>/articles/123/
when passing through to share target. Kind of how thehref
of an<a>
element is understood correctly when it's just/articles/123/
./articles/123/
as the "URL" to any share target.I'm happy to work on this as a PR to this project but wanted to propose it first and get approval before investing the work.
The text was updated successfully, but these errors were encountered: