Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config roots in README #21

Open
heyrict opened this issue Mar 13, 2022 · 4 comments
Open

Update config roots in README #21

heyrict opened this issue Mar 13, 2022 · 4 comments

Comments

@heyrict
Copy link
Contributor

heyrict commented Mar 13, 2022

As I work on another issue in your project, I have found that workspace.getConfiguration('bibtex') seems to be located at coc.preferences.bibtex rather than coc.source.bibtex as you documented in README.md. Probably your documentation should be updated to the latest changes of coc.nvim.

Also, my humble suggestion: As many of the extensions store their config in coc.preferences.*, what do you think about moving list.source.bibtex.* to coc.preferences.bibtex in accordance with other extensions?

Thank you in advance.

@oncomouse
Copy link
Owner

I don't use coc.nvim anymore, which probably explains why the documentation is out of date. I want to make sure I understand here: everything listed as being stored in coc.source.bibtex is now in coc.preferences.bibtex? That should be an easy enough fix.

I can fix the other thing, too. The way coc.nvim handled configurations really bugged me when I wrote this, so I'm glad it's more logical.

@heyrict
Copy link
Contributor Author

heyrict commented Mar 15, 2022

everything listed as being stored in coc.source.bibtex is now in coc.preferences.bibtex

Yes, that's it. I have not fully tested other keys (e.g. list.*) but they seem unchanged.

Thank you for maintaining this package even after your abandoning coc.nvim.

@oncomouse
Copy link
Owner

oncomouse commented Mar 29, 2022

Sorry for not getting back on this sooner, but I just pushed a branch, pref-fix, that implements these changes. Would you mind testing that it's working and I can PR it into the master branch.

EDIT: I just opened a PR, which is referenced below.

@heyrict
Copy link
Contributor Author

heyrict commented Apr 3, 2022

Thank you for your update! I'm sorry for that I have provided the wrong information related to the config location change. Most plugins actually stored their configurations in the object root rather than in coc.preferences. I have pushed a PR (#24) to fix this.

Also, during my testing, changes in bibtex.triggerCharacters and bibtex.triggerPatterns did not have any effects in my settings. Can you give it a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants