Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling show_popups variable doesn't work #6

Open
joined72 opened this issue May 4, 2023 · 1 comment
Open

Disabling show_popups variable doesn't work #6

joined72 opened this issue May 4, 2023 · 1 comment

Comments

@joined72
Copy link

joined72 commented May 4, 2023

Hi, I'm using your plugin and works well (thanks for it), but at the first game run it show the Google Play Game Services Permission Popup, I think it will ask permission to modify or delete google play services data or something.

How do we prevent this to happen ?

I think user will be scared to continue playing the game when we asked permission to modify their Google Play Services and most will probably uninstalled the game when they read the popup dialog.

I just tried setting:

var show_popups := false
var request_email := false
var request_profile := false
var request_token := ""

but the result it's always the same.

@joined72
Copy link
Author

joined72 commented May 4, 2023

I think to have found the solution but I'm not still able to rebuild the plugin.

I think the solution is change the following PlayGameServicesGodot.kt lines:

    runOnUiThread {
        signInController.setShowPopups(enablePopups)
    }

in the following:

    signInController.setShowPopups(enablePopups)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant