Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies from Dependency Manager to a deployment account #1362

Closed
Tracked by #1390
chasefleming opened this issue Jan 30, 2024 · 1 comment · Fixed by #1479
Closed
Tracked by #1390

Add dependencies from Dependency Manager to a deployment account #1362

chasefleming opened this issue Jan 30, 2024 · 1 comment · Fixed by #1479
Assignees
Labels
Feature A new user feature or a new package API

Comments

@chasefleming
Copy link
Member

chasefleming commented Jan 30, 2024

When installing dependencies using the Dependency Manager, the subsequent step involves adding the contracts you wish to deploy to the deployments section of your flow.json. This can be approached in a couple of ways:

  • The process could be automatic, where it is assumed that you likely want to deploy the contracts to the emulator-account, unless specified otherwise through a flag.
  • Alternatively, the default approach should not be to automatically add the contracts. Instead, there could be an option to use a flag to add them to deployments.

The command could look something like:

flow deps add testnet://35717efbbce11c74.Find --deployment-account=emulator-account

Note: you can also default to the emulator-account and then if an account is provided override it.

@chasefleming chasefleming added the Feature A new user feature or a new package API label Jan 30, 2024
@chasefleming chasefleming self-assigned this Jan 30, 2024
@chasefleming chasefleming moved this to 🧊 Backlog in 🌊 Flow 4D Jan 30, 2024
@chasefleming chasefleming changed the title Add depedencies from Dependency Manager to a deployment account Add dependencies from Dependency Manager to a deployment account Feb 8, 2024
@chasefleming chasefleming moved this from 🧊 Backlog to 🔖 Ready for Pickup in 🌊 Flow 4D Feb 8, 2024
@chasefleming
Copy link
Member Author

After thinking about it a bit, a better option might actually be an interactive approach. It could ask you on installing/adding if you want to add the contract it finds to deployments, detect the accounts available, and let you select which to add it to. There could also be an option for --skip-deployments if you are running this from a scenario where you'd want to avoid an interactive prompt.

@chasefleming chasefleming moved this from 🔖 Ready for Pickup to 🏗 In Progress in 🌊 Flow 4D Mar 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in 🌊 Flow 4D Mar 28, 2024
@gregsantos gregsantos moved this from ✅ Done to Closed (Cycle 2) in 🌊 Flow 4D Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant