Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow version output bug #1490

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Fix flow version output bug #1490

merged 2 commits into from
Apr 2, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 2, 2024

Closes #1489

Description

Fix flow version output to use stdout instead & remove log package use (not necessary, can be done via RunE in cobra, & this way exit code is also correct, was returning exit 0 always previously)


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Apr 2, 2024
@jribbink
Copy link
Contributor Author

jribbink commented Apr 2, 2024

Just ran the command again, and cobra seems to be printing usage information + printing the error twice when RunE encounters an error... looking for a workaround.

@jribbink jribbink merged commit 783914c into master Apr 2, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/fix-flow-version branch April 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flow version output is logged to stderr & includes timestamps
3 participants