Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] In-Toolbar Mini Terminal #760

Open
drfarrell opened this issue Nov 7, 2024 · 2 comments
Open

[feat] In-Toolbar Mini Terminal #760

drfarrell opened this issue Nov 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@drfarrell
Copy link
Collaborator

The terminal would sit on the right side of the toolbar. When a user clicks the button it expands the terminal into a minified view.
image

Minified terminal view
image
image

The statuses:

  • Red for failed / fatal error + Exclamation triangle icon
  • Yellow for errors but still able to run the app + Stop to show the app is running
  • Yellow + Play to show you can run the app even if there are errors. Make the outline and text yellow.
  • Green + Stop to show the app is running.
  • Green + Play to show the app can run. Just show the regular default button

The buttons on the bottom just insert and run the commands. The goal is to make it so new users to the terminal can learn how to use it through the buttons.

  • Run the App = npm run dev (or whatever command makes the most sense)
  • Stop the App = CTRL + C
  • Clear = clear
  • Open current directory = open the user's folder in Finder. We'll probably want to add in a "List" (ls) functionality but we'll see what else we need

There are a few steps for this:

  1. Make the Terminal actually work
  2. Make the Terminal UI in the toolbar (Abhiroop used https://www.npmjs.com/package/react-terminal-ui as a quick UI out of the box)
  3. Make the UI work with the Terminal
  4. Make the Command buttons work

The design doesn't show the entire scope of everything, but let me know if you have questions.

@drfarrell drfarrell added the enhancement New feature or request label Nov 7, 2024
@drfarrell
Copy link
Collaborator Author

@Kitenite should we close this out? There are a bunch of smaller improvements we can probably move to other issues.

@Kitenite
Copy link
Contributor

Kitenite commented Dec 3, 2024

Up to you, we can rename it as well

@Kitenite should we close this out? There are a bunch of smaller improvements we can probably move to other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants