Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smile.unmodify handles ZWJ sequences in potentially unexpected ways #26

Open
Sweeper777 opened this issue Oct 7, 2021 · 2 comments
Open

Smile.unmodify handles ZWJ sequences in potentially unexpected ways #26

Sweeper777 opened this issue Oct 7, 2021 · 2 comments

Comments

@Sweeper777
Copy link

Consider 👩🏻‍❤️‍💋‍👨🏼, which is formed of

  • 👩 (woman)
  • Light Skin Tone
  • ZERO WIDTH JOINER
  • HEAVY BLACK HEART
  • VARIATION SELECTOR-16
  • ZERO WIDTH JOINER
  • 💋 (kiss mark)
  • ZERO WIDTH JOINER
  • 👨 (man)
  • Medium-light Skin Tone

If I do

Smile.unmodify(emoji: "👩🏻‍❤️‍💋‍👨🏼")

Everything except the 👩 is removed. This completely changes the meaning of the emoji, which I don't think unmodify is supposed to do. I had expected 👩‍❤️‍💋‍👨 instead. Is this intentional?
@onmyway133
Copy link
Owner

Hi, it is expected to keep just the "prominent" info. Maybe you can try disassemble method ?

@Sweeper777
Copy link
Author

Ah, so you have another method for this purpose :) disassemble does remove the modifiers, which is what I want. However, it also removes the heart :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onmyway133 @Sweeper777