Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Allow number as valid role and grant type (fixes #93) #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(feat) Allow number as valid role and grant type (fixes #93) #94

wants to merge 2 commits into from

Conversation

vegerot
Copy link

@vegerot vegerot commented Nov 20, 2020 •
edited
Loading

In some cases it makes sense to have numbers instead of strings for
role types. For example, when using enums in TypeScript

Fixes #93

@vegerot
(feat) Allow number as valid role and grant type
0b40633 
In some cases it makes sense to have `number`s instead of `string`s for
role types.  For example, when using `enum`s in TypeScript

Fixes onury#93
@vegerot vegerot mentioned this pull request Nov 20, 2020
Closed
@coveralls
Copy link

coveralls commented Nov 20, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 96.907% when pulling 0b40633 on vegerot:valid_number_role into c91eb67 on onury:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow number as valid type of role
2 participants
@vegerot @coveralls