Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny Improvement? #33

Open
owengalenjones opened this issue Feb 21, 2017 · 4 comments
Open

Tiny Improvement? #33

owengalenjones opened this issue Feb 21, 2017 · 4 comments

Comments

@owengalenjones
Copy link
Contributor

Working through these, I noticed in challenge 3-1 there's two functions interpose-space and interpose-pipe. It was odd seeing two specific fn's so soon after learning about generalized fn's with :onyx/params. Not sure if it's useful but seems like it could reinforce best-(?)-practices.
@gardnervickers
Copy link
Member

I like that idea a lot! Something like interpose-character instead?

@owengalenjones
Copy link
Contributor Author

Yep! I can draft a PR if you want, just wanted to confirm whether or not this would actually be an improvement first :)

@MichaelDrogalis
Copy link
Contributor

@owengalenjones Sure, thanks! 👍

@owengalenjones
Copy link
Contributor Author

@MichaelDrogalis whats up Mike :)

@owengalenjones owengalenjones mentioned this issue Feb 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@owengalenjones @MichaelDrogalis @gardnervickers