Connecting line (i.e. text drawn 'over' the stroke of a circle)

[flo80]

For an app we are working on, we wanted to have a visible circle with arced text (middle alignment). Since we paint this over a custom background we cannot just paint text with black background but needed to draw the remaining arc of the circle.

If this is an interesting feature for integration please let me know and I can create a PR.
You can have a look in my fork (note: still based on last non null-safe version of arc_text, will probably upgrade it in the coming days)

[ookami-kb]

I'm not sure that I understand what you mean. Can you please provide a screenshot?

[ookami-kb]

Yeah, something like visitor pattern for the painter makes sense.

[monsieurtanuki]

I think a callback function wouldn't be a good option because:

1. it would prevent the use of the angle before the text is drawn - e.g. for an arc text specific background
2. IMO the notion of "callback" is attached to some asynchronous code to be triggered when some other asynchronous code ends but we have no idea when - in our case we know exactly when (at the end of the arc text paint), and we don't want the second code to be played asynchronously

I don't know about the visitor pattern.

The goals are:

1. I want to display an arc text (we can do that today, perfect!)
2. I want to know the start and end angle of an arc text without having to paint it

A solution could be just a method with tons of code reuse: "normal" users that just want to display an arc text like today wouldn't care about it , and "advanced" users would call it before or after the arc text paints.

[monsieurtanuki]

@flo80 To answer your previous question (and as in @ookami-kb's sample code), I just use getFinalAngle.
Perhaps additional methods getStartAngle(double finalAngle) and getEndAngle(double finalAngle) would make things easier and we wouldn't have to use pi/2 and stuff like that. It is possible in dart to make those methods belong to enum StartAngleAlignment?

[flo80]

@ookami-kb to have a simpler discussion what could work, I create PR #16 with a very simple method that allows painting before the text is drawn

@monsieurtanuki I think 'callback' was just a wrong wording, I just want a method which allows custom painting before the arc text is painted which has access to the angle information (without all the boilerplate required as in the example above)

[ookami-kb]

I was thinking about something like this: #17

This PR introduces a couple of breaking changes, but they should be simple.

[ookami-kb]

@flo80 @monsieurtanuki

Version 0.5.0 published with the latest changes. Thanks a lot for your help!