Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content rating filter not working #6

Open
koinsj opened this issue Jul 9, 2023 · 1 comment
Open

Content rating filter not working #6

koinsj opened this issue Jul 9, 2023 · 1 comment

Comments

@koinsj
Copy link

koinsj commented Jul 9, 2023

I unticked all the content rating filter options then started sniffing and searched for some random stuff, the url was like this:
https://api.mangadex.org/manga?title=Random&limit=10&offset=0&contentRating%5B%5D=safe&contentRating%5B%5D=suggestive&contentRating%5B%5D=erotica&includes%5B%5D=cover_art&includes%5B%5D=author&order%5Brelevance%5D=desc

Then I only ticked the safe option and did the search again, this time the url was like this:
https://api.mangadex.org/manga?title=Random&limit=10&offset=0&contentRating%5B%5D=safe&contentRating%5B%5D=suggestive&contentRating%5B%5D=erotica&includes%5B%5D=cover_art&includes%5B%5D=author&order%5Brelevance%5D=desc&contentRating%5B%5D=safe

I noticed that the filter option was added to the end of the url, but other options like suggestive and erotica were still present in the url. I guess that’s why I could still see those results even if I only ticked the safe option.

Sorry if my English is a bit poor.

@oolxg oolxg closed this as completed in c038c91 Jul 12, 2023
@koinsj
Copy link
Author

koinsj commented Jul 12, 2023

Thank you for the update! But I'm afraid there has been a misunderstanding. I was not saying that you could enable other content ratings along with the ‘safe’. What I meant was the contentRating in the mangadex api url wasn’t updated properly.

When all content ratings were disabled, these sections were still in the api url:
contentRating[]=safe&contentRating[]=suggestive&contentRating[]=erotica

And when all content ratings were enabled, other contentRating sections were added to the end of the api url:
contentRating[]=erotica&contentRating[]=pornographic&contentRating[]=safe&contentRating[]=suggestive

That made the whole api url look like this:
https://api.mangadex.org/manga?title=Random&limit=10&offset=0&contentRating%5B%5D=safe&contentRating%5B%5D=suggestive&contentRating%5B%5D=erotica&includes%5B%5D=cover_art&includes%5B%5D=author&order%5Brelevance%5D=desc&contentRating%5B%5D=erotica&contentRating%5B%5D=pornographic&contentRating%5B%5D=safe&contentRating%5B%5D=suggestive

‘safe’, ‘suggestive’ and ‘erotica’ were repeated in the url, so they would keep showing in the search result no matter you enabled them or not.

(By the way, I feel that ‘safe’ and other ratings should be able to be chosen at the same time in case someone wants to see all results. )

@oolxg oolxg reopened this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants