Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepmerge component not available #730

Open
tariqinaam opened this issue Feb 21, 2017 · 7 comments
Open

deepmerge component not available #730

tariqinaam opened this issue Feb 21, 2017 · 7 comments

Comments

@tariqinaam
Copy link

tariqinaam commented Feb 21, 2017

After upgrading html5-skin to 4.11.13/14 from 4.10.6, I get error of 'deepmerge is not a function'
I tried to isolate this issue and it seems if there is requirejs is on the page, then this specific error occur. I am not loading html5-skin or other ooyala player component via requirejs.
Same site work fine with 4.10.6
Exact console log error is:

Uncaught TypeError: DeepMerge is not a function at Html5Skin.loadConfigData (html5-skin.js:6306) at Html5Skin.<anonymous> (html5-skin.js:5727) at fire (core.js:2247) at Object.fireWith [as resolveWith] (core.js:2357) at done (core.js:9076) at XMLHttpRequest.callback (core.js:9791)

@mistermendez
Copy link
Contributor

Try npm install.

deepMerge was added as a dependency in package.json in 4.11.13.

@tariqinaam
Copy link
Author

tariqinaam commented Feb 22, 2017

I did try npm install and it stil couldn't fix.
When I try load html5-skin via requirejs, it fixes the deepmerge unknown function error but then it throws
Mismatched anonymous define() module: function ()
I think this is more of a deepmerge library issue with requirejs.. Just wondering if anyone tried to use it requirejs.

@tariqinaam
Copy link
Author

tariqinaam commented Feb 27, 2017

I have tried all possible way but it doesn't work with requirejs.
It complain about deepmerge not available. I have tried bundled html5-skin js as well.

has anyone able to make this work with requirejs

@spaddon
Copy link

spaddon commented May 25, 2017

@tariqinaam

Since there's an incompatibility between deepmerge and Require.js, the html5-skin needs to be loaded separately. Additionally, whenever you load incompatible scripts along with RequireJS, you need to make sure to load the RequireJS script after these other scripts load. More on this here: https://stackoverflow.com/questions/15371918/mismatched-anonymous-define-module

TehShrike added a commit to TehShrike/html5-skin that referenced this issue Jun 13, 2017
@TehShrike
Copy link

[email protected] exposes a CommonJS entry point via the pkg.browser field, so if you rebuild with 1.4.0 or later, people using AMD modules shouldn't have any issues. A pull request is open to bump the version: #759.

@welikeideas
Copy link

Are there any plans to release a version of the player with [email protected]?

@alanoooyala
Copy link

This is being discussed. [Our ref: PBW-6804]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants