Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonlinear VPAID overlay ad container not visible #767

Open
ocundale opened this issue Jul 25, 2017 · 0 comments
Open

Nonlinear VPAID overlay ad container not visible #767

ocundale opened this issue Jul 25, 2017 · 0 comments

Comments

@ocundale
Copy link

ocundale commented Jul 25, 2017

When an overlay ad is displayed, the container should be made visible and I can see this is attempted through the following style rule:
.oo-player-skin-plugins.oo-overlay-showing:not(:empty) { display: block; }

This is assigned when the overlay is showing and the container is 'not empty'. However, an additional line to update the z-index is also needed, as otherwise the container is obscured by the div with classes "oo-state-screen" and "oo-start-screen".

Please see the following PR for the suggested change: https://github.com/ooyala/html5-skin/pull/768/files

Example NonLinear Overlay test page: https://featured.dugout.com/preroll-test/coull.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant