Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug report: clipboard-copy function #168

Open
ycyaoxdu opened this issue Dec 3, 2021 · 5 comments
Open

bug report: clipboard-copy function #168

ycyaoxdu opened this issue Dec 3, 2021 · 5 comments
Assignees

Comments

@ycyaoxdu
Copy link
Member

ycyaoxdu commented Dec 3, 2021

While using the copy function for coping the code snippet, I found it doesn't works properly:

When i clicked the copy of step 2 code snippet 1 here, what i get in my clipboard is :

$ kubectl -n open-cluster-management   get pod   --context ${CTX_HUB_CLUSTER}
NAME                               READY   STATUS    RESTARTS   AGE
cluster-manager-695d945d4d-5dn8k   1/1     Running   0          19d

the non-command lines which don't start with a $ is also been copied.

I'm wondering that if it is ok for just add a judgment rule to the copy function to determine whether the line is stared with $ which means that it is a command should be copied.

@qiujian16
Copy link
Member

/assign @morvencao

@morvencao
Copy link
Member

morvencao commented Dec 7, 2021

@ycyaoxdu It's not hard to trim the prompt character $, but what about the command output?
A better solution IMO would be putting the command itself and command output in different html element.

/enhance

@morvencao
Copy link
Member

morvencao commented Dec 7, 2021

And also what if we have multiple commands in a code block, for example:

$ echo "Hello" >file.txt
$ cat file.txt
Hello

@xuezhaojun
Copy link
Member

@morvencao Is this considered done?

@morvencao
Copy link
Member

not yet, I will find time for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants