Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for #skiprows and #headerrows in spreadsheet validation error messages #122

Open
duncandewhurst opened this issue Sep 23, 2019 · 4 comments
Labels
spreadsheet input Relating to when a spreadsheet is provided as input

Comments

@duncandewhurst
Copy link
Contributor

The row number reported in spreadsheet validation error messages is incorrect when the #skiprows or #headerrows configuration properties are set.

For example, in the data which generated the following error message (a spreadsheet with #skiprows set to 2 and #headerrows set to 5) the error is actually on row 8, not row 2:

image

The row reported in the error message should account for the configuration properties set in the source spreadsheet.

@robredpath robredpath transferred this issue from OpenDataServices/cove Oct 14, 2020
@robredpath
Copy link
Contributor

@stevieflow @Bjwebb will this affect IATI CoVE as well?

@robredpath robredpath transferred this issue from another repository Oct 14, 2020
@jpmckinney jpmckinney changed the title OCDS: Account for #skiprows and #headerrows in spreadsheet validation error messages Account for #skiprows and #headerrows in spreadsheet validation error messages Oct 14, 2020
@jpmckinney jpmckinney added the spreadsheet input Relating to when a spreadsheet is provided as input label Oct 14, 2020
@stevieflow
Copy link

@robredpath I've observed this in IATI CoVE too, but not reported it ! So, fixing this would be a benefit

@jpmckinney
Copy link
Member

For whom is this an issue among OCDS users?

@duncandewhurst
Copy link
Contributor Author

Anyone who uses the data collection spreadsheet or previous iterations of input templates for OCDS and OCDS for PPPs.

A previous iteration was in use by Los Angeles (although I believe that project has now finished) and the data collection spreadsheet is in use by some Nigerian states and has been shared with various other partners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spreadsheet input Relating to when a spreadsheet is provided as input
Projects
None yet
Development

No branches or pull requests

4 participants