Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternatives for documento_proveedor #193

Open
jpmckinney opened this issue Nov 6, 2023 · 3 comments
Open

Consider alternatives for documento_proveedor #193

jpmckinney opened this issue Nov 6, 2023 · 3 comments
Labels
enhancement New feature or request topic: sources Relating to data sources

Comments

@jpmckinney
Copy link
Member

For errors like "No borrower identifier in documento_proveedor='No Definido'", is there another field that can be used?

I don't know the meaning of entidad vs proveedor (entidad seems to mean buyer, but later the borrower endpoint uses nit_entidad={documento_proveedor} and codigo_entidad={codigo_proveedor}, so I'm confused), but maybe some options:

  • nit_entidad
  • codigo_entidad
  • codigo_proveedor
@jpmckinney jpmckinney added enhancement New feature or request operations labels Nov 6, 2023
@yolile
Copy link
Member

yolile commented Nov 10, 2023

entidad seems to mean buyer, but later the borrower endpoint uses nit_entidad={documento_proveedor} and codigo_entidad={codigo_proveedor}, so I'm confused

Yeap, everywhere else entidad means buyer, but that particular endpoint returns data from both, buyers and suppliers, and they use "nit_entidad" and "codigo_entidad" for both. So in that endpoint only, entidad means what in OCDS would be a party.

With that said, we could use codigo_proveedor. But this field is for the code that SECOP assigns to the supplier, not a legal identifier (as documento_proveedor is), and Credere and the FIs need a legal identifier. In one example I found from the logs: https://www.datos.gov.co/resource/jbjy-vk9h.json?$where=proceso_de_compra=%27CO1.BDOS.4833182%27 It seems that this is a consortium (es_grupo='Si'). So maybe we need to include es_grupo='No' in our main query (or include documento_proveedor is not 'No Definido' to avoid this issue)

@jpmckinney
Copy link
Member Author

Does Credere need a legal identifier, or can that be collected from the borrower as part of the application?

@yolile
Copy link
Member

yolile commented Nov 10, 2023

At the moment Credere uses the legal identifier to calculate the unique hash for the MSME and the application. If we change the ID source I guess we will need to change that as well, besides the changes for requesting the legal identifier as part of the MSME application. With that said, we can leave this issue as an improvement for the future. I can also check if this issue always happens with consortiums or if it also happens with regular suppliers. The consortium part is important because we know our current FI doesn't accept consortiums anyway (e.g they can only provide the credit to one member of the consortium, at most)

@yolile yolile added this to the Post-MVP milestone Nov 10, 2023
@yolile yolile moved this to 📋 Backlog in Credere optimization backlog May 7, 2024
@jpmckinney jpmckinney removed this from the Post-MVP milestone Aug 9, 2024
@jpmckinney jpmckinney added topic: sources Relating to data sources and removed operations labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: sources Relating to data sources
Projects
No open projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants