Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused model fields #388

Closed
jpmckinney opened this issue Aug 22, 2024 · 3 comments · Fixed by #407
Closed

Unused model fields #388

jpmckinney opened this issue Aug 22, 2024 · 3 comments · Fixed by #407
Assignees
Labels
chore topic: documentation Improvements or additions to documentation

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Aug 22, 2024

Are these planned for future use?

  • Lender
    • status
    • deleted_at
  • User
    • language

I'm also not really sure what Lender.type affects on the frontend.

@jpmckinney jpmckinney added topic: documentation Improvements or additions to documentation chore labels Aug 22, 2024
@yolile
Copy link
Member

yolile commented Sep 5, 2024

Lender status, deleted_at

I guess these fields would be useful if we ever need to offboard a Lender

User language

We are not using this one at all, as we select the language depending on the front-end request

I'm also not really sure what Lender.type affects on the frontend.

It is part of the lender on boarding form, but we are not using it for something in particular at the moment

@jpmckinney
Copy link
Member Author

Ok, I'll just document them as unused. In future, we might just drop them in a migration.

I also notice that it's a bit weird that Lender.logo_filename refers to a file that is stored in git in credere-frontend... It would make more sense to store the logo as bytes in the DB.

@yolile
Copy link
Member

yolile commented Sep 6, 2024

I also notice that it's a bit weird that Lender.logo_filename refers to a file that is stored in git in credere-frontend... It would make more sense to store the logo as bytes in the DB.

Of course, see #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore topic: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants