Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send external onboarding reminders: change dates logic #439

Open
yolile opened this issue Oct 30, 2024 · 1 comment
Open

Send external onboarding reminders: change dates logic #439

yolile opened this issue Oct 30, 2024 · 1 comment
Labels
chore
Milestone
Priority

Comments

@yolile
Copy link
Member

yolile commented Oct 30, 2024

That said, we could keep the code as-is, and open an issue so that in 30 days (Dec 1), we delete this Message logic are use the simpler borrower_submitted_at logic.

Originally posted by @jpmckinney in #438 (comment)
jpmckinney added a commit that referenced this issue Oct 30, 2024
@jpmckinney
chore: Use "before lapsed" logic like with other timeline logic. Use …
eceec22 
…"remind_at" logic for now, #439
This was referenced Oct 30, 2024
Merged
Closed
jpmckinney added a commit that referenced this issue Oct 30, 2024
@jpmckinney
chore: Uncomment new code for external onboarding reminders, #439
c89a1f8
@jpmckinney
Copy link
Member

Can search for noqa: ERA001 for the code to change.

@jpmckinney jpmckinney added this to the Priority milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
Priority
Development

No branches or pull requests
2 participants
@jpmckinney @yolile