Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsector further clarity needed #356

Open
odscrachel opened this issue Jun 27, 2022 · 4 comments
Open

Subsector further clarity needed #356

odscrachel opened this issue Jun 27, 2022 · 4 comments
Labels
documentation This issue relates to the documentation IDS This issue relates to modelling an element from the CoST IDS

Comments

@odscrachel
Copy link
Contributor

In our mapping guidance subsector from IDS is mapped to additionalClassifications and is described as 'Develop a subset for each sector e.g. Transport could be subdivided into national highway, local road, railway, port, airport etc. ' Whereas the schema browser describes additionalClassifications as 'One or more additional project classifications can be provided to describe the social or economic focus of the project.'.
This seems confusing. Especially when sector is already made up of [sector].[subsector]

@odscrachel odscrachel added documentation This issue relates to the documentation IDS This issue relates to modelling an element from the CoST IDS labels Jun 27, 2022
@jpmckinney
Copy link
Member

You're looking at the "from OCDS" page, but maybe it's clearer on the "from IDS" page? https://standard.open-contracting.org/infrastructure/latest/en/cost/?#identification

@odscrachel
Copy link
Contributor Author

Ah yes, I added the wrong link, but the issue still stands.

@jpmckinney
Copy link
Member

jpmckinney commented Jun 28, 2022

Hmm, yes, I suppose we need to change the guidance to be to add a .suffix to sector rather than use additionalClassifications. What do you think, @duncandewhurst ? (Also, welcome back!)

It might be a bit tricky to word clearly (e.g. if the sector isn't present in the open codelist).

@duncandewhurst
Copy link
Contributor

Good spot @odscrachel. I agree with @jpmckinney's suggestion (and thanks, it's good to be back!)

I think we should also:

  • Keep the reference to additionalClassifications in the mapping for Sector, in case implementers want to also publish their own classifications in addition to mapping to the sector codelist.
  • Update the description of additionalClassifications to mention sector classifications.

@duncandewhurst duncandewhurst added this to the Iterative improvements milestone Jul 13, 2022
@odscrachel odscrachel self-assigned this Aug 8, 2022
@odscrachel odscrachel removed their assignment Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue relates to the documentation IDS This issue relates to modelling an element from the CoST IDS
Projects
None yet
Development

No branches or pull requests

3 participants