feat: add collection notes endpoint #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmckinney
reviewed
Dec 13, 2024
process/views.py
Outdated
| @action(detail=True) | ||
| def notes(self, request, pk=None): | ||
| """Return the notes for the compiled collection and its parent collection.""" | ||
| compiled_collection = get_object_or_404(Collection, pk=pk) |
There was a problem hiding this comment.
Why request the compiled collection? I think it'd be more generic to request the root collection, and then get notes from all child collections.
There was a problem hiding this comment.
I was following the same approach as the metadata endpoint, as I thought the registry would probably ask for the compiled collection. But you are right and I will change it to the root collection instead
| @@ -232,6 +232,21 @@ def metadata(self, request, pk=None): | |||
|
|
|||
| return Response(metadata) | |||
|
|
|||
| @action(detail=True) | |||
There was a problem hiding this comment.
The other views use @extend_schema to define the output format. This is only to improve the OpenAPI docs. You can create a follow-up issue instead.
…ngfisher-process into 443-collection-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #443