Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform OCDS to OC4IDS #123

Closed
jpmckinney opened this issue Jan 21, 2020 · 1 comment
Closed

Transform OCDS to OC4IDS #123

jpmckinney opened this issue Jan 21, 2020 · 1 comment
Assignees
@kindly

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Jan 21, 2020 •
edited
Loading

Copying from f703eb9

I'm curious why the design is to loop over the compiled releases in each transform? It seems less efficient than just doing that once.

Given that each transform calls run in __init__, it's not clear to me that a system of multiple classes is simpler than a single class (to maintain any global state) with one method for each transform (e.g. if the OCDS upgrade methods needed to maintain state between transforms, we could just put them all under one big class).
@jpmckinney jpmckinney mentioned this issue Jan 30, 2020
Merged
@jpmckinney
Copy link
Member Author

Address in #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kindly kindly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpmckinney @kindly