-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCDS Lite implementation #154
Comments
@sabahfromlondon The basic version of OCDS Lite (in accordance with the spoonbill library capabilities) is implemented. Please check it out on the website. |
@sorenabell I've just tested this and each sheet has a couple of additional columns that are not required (rowID and parentID). See screenshot columns C and D: I'm assuming that the work to apply user friendly headings is WIP. |
Which sheet(s) have those columns? They might be okay on some sheets. |
Maybe it is connected to this bug open-contracting/spoonbill#90 |
@jpmckinney the columns are on all sheets. Here's a sample flattened file: |
Thanks! Aren't those columns needed in awards_suppliers to easily link with awards? (They aren't needed elsewhere.) Later, when we implement the OCDS Lite version that repeats data across sheets, we won't need them anywhere. |
Ok, but I thought we kept the Awards ID field to link awards_suppliers with awards: https://docs.google.com/spreadsheets/d/1L3CX3m4zh8o3YyKev9NT_pQc3h5eSQ9EmRxYmHXRVh8/edit?usp=sharing |
The trouble is that the Awards ID (from the original OCDS data) is only unique within a given contracting process, so to link the sheets, the user would need to create a composite unique key, combining the OCID and Awards ID. The Row ID/Parent ID make this task easier by providing those keys. |
@sabahfromlondon we've added updated for parentID and rowID for the OCDS Lite. Please check. |
@sorenabell I thought based on James's comment above we would keep the Row ID/Parent ID? |
Based on the James' comment before that #154 (comment) rowID and parentID are necessary only for child tables ( |
The minimum is a rowID in |
Yes, that was implemented. Please check. |
cc @yolile re: testing OCDS Lite. |
@sorenabell I tested this and |
@sorenabell I just tested the OCDS Lite journey again and can see that user friendly headings have been automatically applied which is great. I also tested in Spanish and can see that the user friendly headings are still in English. Just checking that this is still in progress? |
Yes, this is issue #142 |
@sorenabell I can see the |
Seems like this is done based on the above conversation, so closing. Noting that #300 is still open and related. |
OCDS Lite Data template: https://docs.google.com/spreadsheets/d/1ov6IwG3c8CZTh7W9tZOw_VbVRen2oNNR1j1GnHSkufk/edit?usp=sharing
The text was updated successfully, but these errors were encountered: