Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCDS Lite implementation #154

Closed
sorenabell opened this issue Apr 29, 2021 · 20 comments · Fixed by #221 or #265
Closed

OCDS Lite implementation #154

sorenabell opened this issue Apr 29, 2021 · 20 comments · Fixed by #221 or #265
Assignees

Comments

@sorenabell
Copy link
Contributor

sorenabell commented Apr 29, 2021

OCDS Lite Data template: https://docs.google.com/spreadsheets/d/1ov6IwG3c8CZTh7W9tZOw_VbVRen2oNNR1j1GnHSkufk/edit?usp=sharing

@sorenabell
Copy link
Contributor Author

@sabahfromlondon The basic version of OCDS Lite (in accordance with the spoonbill library capabilities) is implemented. Please check it out on the website.

@sabahfromlondon
Copy link

@sorenabell I've just tested this and each sheet has a couple of additional columns that are not required (rowID and parentID). See screenshot columns C and D:

Screenshot 2021-05-25 152520

I'm assuming that the work to apply user friendly headings is WIP.

@jpmckinney
Copy link
Member

Which sheet(s) have those columns? They might be okay on some sheets.

@sorenabell
Copy link
Contributor Author

Maybe it is connected to this bug open-contracting/spoonbill#90

@sabahfromlondon
Copy link

@jpmckinney the columns are on all sheets. Here's a sample flattened file:
result_GhxKFzP.xlsx

@jpmckinney
Copy link
Member

jpmckinney commented May 25, 2021

Thanks! Aren't those columns needed in awards_suppliers to easily link with awards? (They aren't needed elsewhere.)

Later, when we implement the OCDS Lite version that repeats data across sheets, we won't need them anywhere.

@sabahfromlondon
Copy link

Ok, but I thought we kept the Awards ID field to link awards_suppliers with awards: https://docs.google.com/spreadsheets/d/1L3CX3m4zh8o3YyKev9NT_pQc3h5eSQ9EmRxYmHXRVh8/edit?usp=sharing

@jpmckinney
Copy link
Member

jpmckinney commented May 26, 2021

The trouble is that the Awards ID (from the original OCDS data) is only unique within a given contracting process, so to link the sheets, the user would need to create a composite unique key, combining the OCID and Awards ID. The Row ID/Parent ID make this task easier by providing those keys.

@sorenabell
Copy link
Contributor Author

@sabahfromlondon we've added updated for parentID and rowID for the OCDS Lite. Please check.

@sabahfromlondon
Copy link

@sorenabell I thought based on James's comment above we would keep the Row ID/Parent ID?

@sorenabell
Copy link
Contributor Author

Based on the James' comment before that #154 (comment) rowID and parentID are necessary only for child tables (awards_suppliers in this case). Is that still correct?

@jpmckinney
Copy link
Member

Based on the James' comment before that #154 (comment) rowID and parentID are necessary only for child tables (awards_suppliers in this case). Is that still correct?

The minimum is a rowID in awards and a parentID in awards_suppliers (whose values match a rowID in awards). These unique keys will allow the user to perform a lookup between the tables.

@sorenabell sorenabell linked a pull request Jun 14, 2021 that will close this issue
@sorenabell
Copy link
Contributor Author

Yes, that was implemented. Please check.

@jpmckinney
Copy link
Member

cc @yolile re: testing OCDS Lite.

@yolile
Copy link
Member

yolile commented Jun 14, 2021

@sorenabell I tested this and open-contracting/spoonbill#105 and open-contracting/spoonbill#67 persist. Also, the "ocid" column is missed in the "awards" and "awards_supplier" sheets. It seems that the ocid column was incorrectly removed in #265

@mariob0y
Copy link
Contributor

Also, the "ocid" column is missed in the "awards" and "awards_supplier" sheets. It seems that the ocid column was incorrectly removed in #265

@yolile ocid absence is fixed now - #271

@sabahfromlondon
Copy link

@sorenabell I just tested the OCDS Lite journey again and can see that user friendly headings have been automatically applied which is great.

I also tested in Spanish and can see that the user friendly headings are still in English. Just checking that this is still in progress?

@sorenabell
Copy link
Contributor Author

Yes, this is issue #142

@sabahfromlondon
Copy link

sabahfromlondon commented Jun 24, 2021

@sorenabell I can see the ocid in all sheets now

@sorenabell sorenabell modified the milestones: 2.0, 3.0 Sep 30, 2021
@jpmckinney jpmckinney removed this from the 3.0 milestone Dec 15, 2021
@jpmckinney
Copy link
Member

jpmckinney commented Dec 15, 2021

Seems like this is done based on the above conversation, so closing.

Noting that #300 is still open and related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants