Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-level arrays added by extensions are omitted from the output #205

Open
yolile opened this issue May 19, 2021 · 3 comments · Fixed by #114
Open

Top-level arrays added by extensions are omitted from the output #205

yolile opened this issue May 19, 2021 · 3 comments · Fixed by #114
Labels
bug Something isn't working
Milestone

Comments

@yolile
Copy link
Member

yolile commented May 19, 2021

Tested with https://www.contrataciones.gov.py/datos/api/v3/doc/ocds/releases/id/394282-adquisicion-cubiertas-maquinarias-vehiculos-utilitarios-annp-1-1621414358

The planning section has two arrays: budgetBreakdown and items (both extensions) but the tool reports "There are 0 arrays in this tables"

image

ref: https://ocp12.open-contracting.org/#/customize-tables/8201631b-7cfc-4ccc-b9af-5293963777fd?url=a0ed7e3c-1e08-401e-8013-6dbd4cad3b66&selections=78e7dd2e-531b-46e4-b137-2dde5a0be806

Similarly, for the same JSON, the tender section has 5 arrays at the tender level (items, lots, notifiedSuppliers, criteria, documents) but only 3 are reported.

If I select the "Split arrays" option, I get only the tender/items related tables (and with 0 rows each):
image

Finally, the JSON also has an array at the release level: "sources", and that one doesn't appear anywhere.

@yolile
Copy link
Member Author

yolile commented May 19, 2021

Update: the problem seems to be with top-level array extensions only, as the extensions at the item level (sub-array) are detected correctly cc @jpmckinney

@sabahfromlondon
Copy link

sabahfromlondon commented Jun 3, 2021

@sorenabell I just tested this again with the file @yolile provided and the interface is still saying that there are "There are 0 arrays in this tables" for the planning table

Screenshot 2021-06-03 144335

@sorenabell sorenabell reopened this Jun 3, 2021
@sorenabell sorenabell assigned mariob0y and unassigned VDigitall and yshalenyk Jun 3, 2021
@jpmckinney
Copy link
Member

Noting that this leads to data from the JSON being missing from the tables, notably bids data.

@jpmckinney jpmckinney changed the title Dec 15, 2021
@jpmckinney jpmckinney transferred this issue from open-contracting/spoonbill-web Dec 15, 2021
@jpmckinney jpmckinney added the bug Something isn't working label Dec 15, 2021
@jpmckinney jpmckinney added this to the Priority milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants