Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counts are 0-indexed #222

Open
jpmckinney opened this issue Sep 19, 2023 · 0 comments
Open

counts are 0-indexed #222

jpmckinney opened this issue Sep 19, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@jpmckinney
Copy link
Member

Most of the code seems to consistently use 0-index counts, such that variables like total_rows are actually the total rows minus 1. If this is truly consistent, then there is no bug. That said, it's terribly confusing to count real rows as 0 = 1, 1 = 2, etc.

@jpmckinney jpmckinney added the bug Something isn't working label Sep 19, 2023
@jpmckinney jpmckinney added this to the Priority milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant