Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag should be omitWhenMerged #770

Closed
jpmckinney opened this issue Nov 27, 2018 · 1 comment · Fixed by #810
Closed

tag should be omitWhenMerged #770

jpmckinney opened this issue Nov 27, 2018 · 1 comment · Fixed by #810
Assignees
@jpmckinney
Labels
bug Focus - Merging Relating to the creating of compiled releases and versioned releases
Milestone
1.1.4

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Nov 27, 2018 •
edited
Loading

The behavior of OCDS Merge is to set the tag to compiled for compiledRelease, and to move the tag onto the versioned object for versionedRelease. In other words, the original tag field is omitted.

Assigning to @kindly to confirm. The docs don't describe the first behavior, which we can fix as part of this issue.
@jpmckinney jpmckinney added the Focus - Merging Relating to the creating of compiled releases and versioned releases label Nov 27, 2018
@jpmckinney jpmckinney mentioned this issue Nov 27, 2018
Closed
7 tasks
@jpmckinney jpmckinney modified the milestones: 1.1.x Clarifications, 1.1.4 Nov 27, 2018
@kindly
Copy link
Contributor

kindly commented Dec 6, 2018

@jpmckinney yes this is what I thought was expected behaviour. Was not aware that was not in the docs.
We need to put something in tag at the compiledRelease level as it is a required field.

This relates to #330 (about making a compiledRelease schema) as we could validate this there.

@jpmckinney jpmckinney mentioned this issue Dec 6, 2018
Open
jpmckinney pushed a commit that referenced this issue Dec 6, 2018
tag is omitWhenMerged. Document setting tag to ["compiled"], closes #770
296f77b
jpmckinney added a commit that referenced this issue Feb 1, 2019
@jpmckinney
Set tag to omitWhenMerged, #770, and:
d1ee646 
- Use omitWhenMerged to determine which fields to remove from versioned release schema
- Only include unversioned definitions if needed in versioned release schema
@jpmckinney jpmckinney mentioned this issue Feb 1, 2019
Merged
@jpmckinney jpmckinney added the bug label Feb 1, 2019
@jpmckinney jpmckinney assigned jpmckinney and unassigned kindly Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpmckinney jpmckinney

Labels
bug Focus - Merging Relating to the creating of compiled releases and versioned releases
Projects
None yet
Milestone
1.1.4
Development

Successfully merging a pull request may close this issue.

Fix versioned release schema and merge rules open-contracting/standard
2 participants
@jpmckinney @kindly