Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DIS 7 Electronic Emissions Systems #24

Open
B1Dobbs opened this issue Sep 8, 2023 · 2 comments
Open

Support for DIS 7 Electronic Emissions Systems #24

B1Dobbs opened this issue Sep 8, 2023 · 2 comments

Comments

@B1Dobbs
Copy link

B1Dobbs commented Sep 8, 2023

Noticed a comment in dis7/ElectronicEmissionsPdu that states 'Electronic emmissions systems THIS IS WRONG'. Then the initToBinary uses a Vector3Float instead of a class like DIS 6's ElectronicEmissionSystemData.

Are there any plans to fix this?

@leif81
Copy link
Member

leif81 commented Sep 8, 2023

Thank-you for the report @B1Dobbs

This library is primarily maintained by the community through pull requests as issues or enhancements like this as they are raised. If this issue is important for your use case please feel free to contribute a pull request. Am happy to review and merge changes that are contributed.

@B1Dobbs
Copy link
Author

B1Dobbs commented Sep 11, 2023

I appreciate the quick response! We'll probably look into adding this support a little later and will avoid using DIS7 Emission PDUs for now. Feel free to either close this ticket or leave it open for someone else to work on as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants