Implement type inference for JsonLogic #1

CharString · 2023-08-22T17:18:16Z

setup project using domdomegg/hindley-milner-typescript or hindley-milner-typescript-minimal as the implementations of M/M'/W
implement a parser from JsonLogic to an inference context
define a default context with the type signatures of JsonLogic operators
add the date operations and datetypes defined in maykinmedia/json-logic-py #2
add error tracking #3
add possibility to add type information to the context maybe "auto" as an explicit request for inference.

Based on https://github.com/open-formulieren/types

Vendor the meat of https://github.com/domdomegg/hindley-milner-typescript-minimal Implementations for - Algorithm W L. Damas and R. Milner, "Principal type-schemes for functional programs", Proceedings of the 9th ACM SIGPLAN-SIGACT Symposium on Principles of Programming Languages - POPL '82, 1982. https://doi.org/10.1145/582153.582176 - Algorithm M O. Lee and K. Yi, "Proofs about a folklore let-polymorphic type inference algorithm", ACM Transactions on Programming Languages and Systems, vol. 20, no. 4, p. 707-723, 1998. https://doi.org/10.1145/291891.291892 Vendoring, because we will need to tailor the models to the JsonLogic language. Code in this commit is an exact copy; just reformated with prettier.

About a third of these don't typecheck.

Adds - default Context with type annotations of JsonLogic operations - parser for JsonLogic "rules" - parser for JsonLogic "data" - Number and String literal to the models - Rename and extend the TypeFunctions - handling of Number and String to W

Changes "if", "filter", "and" and "or" to take any type as arguments but the return types should still align. This change just assumes an implicit "!!" call around the boolean arguments.

- Flag some error messages as TODO - Add variadic "if" (which is a chain of elifs) - Add "?:" - Handle more "var" error cases

Adds - default Context with type annotations of JsonLogic operations - parser for JsonLogic "rules" - parser for JsonLogic "data" - Number and String literal to the models - Rename and extend the TypeFunctions - handling of Number and String to W

Changes "if", "filter", "and" and "or" to take any type as arguments but the return types should still align. This change just assumes an implicit "!!" call around the boolean arguments.

- Flag some error messages as TODO - Add variadic "if" (which is a chain of elifs) - Add "?:" - Handle more "var" error cases

joeribekker · 2024-01-12T14:36:37Z

Type inference feature was cancelled due to implementation difficulties vs benefits.

CharString added this to Development Aug 22, 2023

github-project-automation bot moved this to Todo in Development Aug 22, 2023

CharString self-assigned this Aug 22, 2023

sergei-maertens mentioned this issue Aug 28, 2023

TypeError: apply_map() missing 1 required positional argument: 'scoped_logic' open-formulieren/open-forms#2941

Open

CharString moved this from Todo to In Progress in Development Oct 17, 2023

CharString added a commit that referenced this issue Nov 9, 2023

🎉[#1] Setup project

8744e93

Based on https://github.com/open-formulieren/types

CharString added a commit that referenced this issue Nov 9, 2023

🧪[#1] Add https://jsonlogic.com/tests.json

aadf080

About a third of these don't typecheck.

CharString added a commit that referenced this issue Nov 9, 2023

✅[#1] Passes all tests

76da06f

- Flag some error messages as TODO - Add variadic "if" (which is a chain of elifs) - Add "?:" - Handle more "var" error cases

CharString added a commit that referenced this issue Nov 13, 2023

✅[#1] Passes all tests

2ceb8e5

- Flag some error messages as TODO - Add variadic "if" (which is a chain of elifs) - Add "?:" - Handle more "var" error cases

joeribekker assigned Viicos Dec 22, 2023

joeribekker removed this from Development Jan 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement type inference for JsonLogic #1

Implement type inference for JsonLogic #1

CharString commented Aug 22, 2023 •

edited

Loading

joeribekker commented Jan 12, 2024

Implement type inference for JsonLogic #1

Implement type inference for JsonLogic #1

Comments

CharString commented Aug 22, 2023 • edited Loading

joeribekker commented Jan 12, 2024

CharString commented Aug 22, 2023 •

edited

Loading