Implement multiple #46
Conversation
svenvandescheur
force-pushed
the
feature/#43-input
branch
5 times, most recently
from
49ee15c to
ffdec37
Compare
svenvandescheur
force-pushed
the
feature/#43-input
branch
from
ffdec37 to
23d7ea7
Compare
There was a problem hiding this comment.
If I understand correctly this is not a "container" in the sense of the "edit grid" or "repeating groups". This is the "multiple values" checkbox on any single field component, right?
I got interrupted and now I have the feeling I had a question I can't remember... I guess it will come up if it's important 🤷
| const remove = (index: number) => { | ||
| const _keys = keys.filter((_, i) => i !== index); | ||
| const val = value.filter((_, i) => i !== index); | ||
| setKeys(_keys); | ||
| setValue(path, val); | ||
| }; |
There was a problem hiding this comment.
For my understanding: we're not allowed to mutate with Array.splice, right?
There was a problem hiding this comment.
I'd avoid mutating array as much as possible.
Yes correct, we need to support third party scenario's so we don't want to complicate components too much with this in order. Containers are slightly more tightly coupled with the renderer to take away unwanted complexity. |
|
I still have to adjust the validation system to work correctly with multiple values. |
svenvandescheur
force-pushed
the
feature/#43-input
branch
from
427c11e to
1d218c0
Compare
svenvandescheur
force-pushed
the
feature/#43-input
branch
from
1d218c0 to
e9506c6
Compare
|
Sorry, closing this - when we pick up this development again (builder currently has prio since translation management is broken), I will do this via #47 which wipes out most of this implementation path. |
Closes #43