From 8908faacf6ac9fd48726d8c5320ba3794f9d85db Mon Sep 17 00:00:00 2001
From: Sergei Maertens <sergei@maykinmedia.nl>
Date: Fri, 20 Oct 2023 15:59:34 +0200
Subject: [PATCH] :recycle: [#571] Refactor formio content component styling

The class name is now set directly on the WYSIWYG container and the
custom classes are applied as modifiers instead of standalone/
utility classes, allowing us to clean up our CSS.

Additionally, design tokens (with backwards compatible fallbacks) are
introduced for the theming of each content variant.
---
 src/formio/components/Content.js  |  9 +++---
 src/scss/components/_content.scss | 48 +++++++++++++++++++------------
 2 files changed, 34 insertions(+), 23 deletions(-)

diff --git a/src/formio/components/Content.js b/src/formio/components/Content.js
index b87c4e4db..6cf6bb69b 100644
--- a/src/formio/components/Content.js
+++ b/src/formio/components/Content.js
@@ -1,15 +1,16 @@
 import {Formio} from 'react-formio';
 
+import {getBEMClassName} from 'utils';
+
 /**
  * Extend the default Content field to modify it to our needs.
  */
 class ContentComponent extends Formio.Components.components.content {
   init() {
     super.init();
-    if (!this.component.customClass) {
-      this.component.customClass = '';
-    }
-    this.component.customClass += ' formio-component-content';
+    const {customClass = ''} = this.component;
+    // upstream template is broken (?) and doesn't actually call this.className
+    this.component.className = getBEMClassName('formio-content', customClass ? [customClass] : []);
   }
 }
 
diff --git a/src/scss/components/_content.scss b/src/scss/components/_content.scss
index 3b661b6ba..b3718c4a0 100644
--- a/src/scss/components/_content.scss
+++ b/src/scss/components/_content.scss
@@ -1,31 +1,41 @@
 @use 'microscope-sass/lib/bem';
 @use './anchor';
 
-@import '~microscope-sass/lib/grid';
 @import '~microscope-sass/lib/typography';
 
 @import '../mixins/prefix';
 
-// the html div doesn't get it's own class name, but it is part of the form-control--content
-// component
+$formio-content-variants: 'error', 'warning', 'success', 'info';
 
-.#{prefix(form-control)} {
-  @include bem.modifier('content') {
-    &:not(:first-child) {
-      @include responsive(
-        $properties: margin-top,
-        $value-mobile: $grid-margin-3,
-        $value-tablet: $grid-margin-4
-      );
-      padding-top: 0 !important;
-    }
+@mixin formio-content-variant($variant) {
+  border-inline-start-color: var(
+    --of-formio-content-#{$variant}-border-inline-start-color,
+    var(--of-color-#{$variant})
+  );
+  border-inline-start-style: var(--of-formio-content-#{$variant}-border-inline-start-style, solid);
+  border-inline-start-width: var(--of-formio-content-#{$variant}-border-inline-start-width, 4px);
+  padding-inline-start: var(--of-formio-content-#{$variant}-padding-inline-start, 16px);
+}
+
+// See src/formio/components/Content.js
+.openforms-formio-content {
+  // apply all wysiwyg styling
+  // TODO: parametrize this with design tokens -> check with NL DS how to approach this
+  @include wysiwyg;
+  @include body;
+  @include body--big;
+
+  // Below this line is okay and in line with NL DS principles
+  @include anchor.extend-utrecht-link;
+  inline-size: var(--of-formio-content-inline-size, 100%);
+  max-inline-size: var(
+    --of-formio-content-max-inline-size,
+    var(--utrecht-form-field-max-inline-size)
+  );
 
-    [ref='html'] {
-      @include wysiwyg;
-      @include body;
-      @include body--big;
-      @include anchor.extend-utrecht-link;
-      width: 100%;
+  @each $variant in $formio-content-variants {
+    @include bem.modifier($variant) {
+      @include formio-content-variant($variant);
     }
   }
 }