Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement prefill configuration modal (StoryBook only) #4608

Closed
Tracked by #4266
stevenbal opened this issue Aug 19, 2024 · 1 comment · Fixed by #4610
Closed
Tracked by #4266

Implement prefill configuration modal (StoryBook only) #4608

stevenbal opened this issue Aug 19, 2024 · 1 comment · Fixed by #4610
Assignees
@stevenbal
Labels
enhancement owner: den-haag
Milestone
Release 3.0

Comments

@stevenbal
Copy link
Contributor

stevenbal commented Aug 19, 2024 •
edited
Loading

See wireframe: #4266 (comment)

This is the modal that pops up from the variables tab, the user should define a user defined variable, click the button for the prefill settings and select Objects API (which should change the form fields for the modal to the ones specified in the wireframe)
@stevenbal stevenbal mentioned this issue Aug 19, 2024
Closed
8 tasks
@stevenbal stevenbal self-assigned this Aug 19, 2024
@stevenbal stevenbal mentioned this issue Aug 20, 2024
Closed
stevenbal added a commit that referenced this issue Aug 20, 2024
@stevenbal
🚧 [#4608] initial modal work
48b62c6
@stevenbal stevenbal mentioned this issue Aug 20, 2024
Merged
9 tasks
stevenbal added a commit that referenced this issue Aug 26, 2024
@stevenbal
🚧 [#4608] initial modal work
9c576a2
stevenbal added a commit that referenced this issue Aug 26, 2024
@stevenbal
✨ [#4608] Modal for Objects API prefill options
38b4f5b
stevenbal added a commit that referenced this issue Aug 26, 2024
@stevenbal
✨ [#4608] Modal for Objects API prefill options
c243549
stevenbal added a commit that referenced this issue Aug 26, 2024
@stevenbal
🚧 [#4608] Initial work to add objects apiGroup to prefill config modal
ee1637c
stevenbal added a commit that referenced this issue Aug 26, 2024
@stevenbal
🚧 [#4608] Initial work to add objects apiGroup to prefill config modal
749f185
stevenbal added a commit that referenced this issue Aug 27, 2024
@stevenbal
🚧 [#4608] Initial work to add objects apiGroup to prefill config modal
805ca4e
stevenbal added a commit that referenced this issue Aug 27, 2024
@stevenbal
✨ [#4608] Add objects API group/type/version to prefill modal
c2bba39
stevenbal added a commit that referenced this issue Aug 27, 2024
@stevenbal
✨ [#4608] Modal for Objects API prefill options
0f64dbd
stevenbal added a commit that referenced this issue Aug 27, 2024
@stevenbal
✨ [#4608] Add objects API group/type/version to prefill modal
9424c20
stevenbal added a commit that referenced this issue Aug 27, 2024
@stevenbal
✨ [#4608] More changes to bring into line with backend
5e67b5b
stevenbal added a commit that referenced this issue Sep 17, 2024
@stevenbal
✨ [#4608] Modal for Objects API prefill options
20129b8
stevenbal added a commit that referenced this issue Sep 17, 2024
@stevenbal
✨ [#4608] Add objects API group/type/version to prefill modal
42d69d3
stevenbal added a commit that referenced this issue Sep 17, 2024
@stevenbal
✨ [#4608] More changes to bring into line with backend
be2e20f
stevenbal added a commit that referenced this issue Sep 17, 2024
@stevenbal
♻️ [#4608] Use proper objects API prefill endpoint for modal
17f010b
stevenbal added a commit that referenced this issue Sep 17, 2024
@stevenbal
✨ [#4608] Add objectsApiGroups to objects prefill endpoint
56e208b
stevenbal added a commit that referenced this issue Sep 23, 2024
@stevenbal
✨ [#4608] Modal for Objects API prefill options
a96239b
stevenbal added a commit that referenced this issue Sep 23, 2024
@stevenbal
✨ [#4608] Add objects API group/type/version to prefill modal
09639c3
stevenbal added a commit that referenced this issue Sep 23, 2024
@stevenbal
✨ [#4608] More changes to bring into line with backend
9a0ac09
stevenbal added a commit that referenced this issue Sep 23, 2024
@stevenbal
♻️ [#4608] Use proper objects API prefill endpoint for modal
f52c35f
stevenbal added a commit that referenced this issue Sep 23, 2024
@stevenbal
✨ [#4608] Add objectsApiGroups to objects prefill endpoint
70357d0
stevenbal added a commit that referenced this issue Sep 23, 2024
@stevenbal
✨ [#4608] Bring prefill modal in line with backend
23c3420
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
🚸 [#4608] Add arrows to indicate mapping direction
0819923 
Since there are two columns for source/target in the variable mapping
component, it makes sense to display the direction of assignment
with an arrow.
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
🚚 [#4608] Move useSynchronizeSelect to shared forms package
c632d61 
The hook is actually more broadly usable than in the objects_api, but
for the time being it's only used there.
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
🎨 [#4608] Finetune ObjectsAPIGroup refactor
488e10d 
After moving the ObjectsAPIGroup component to a shared field layer
where the form data structure is unknown at the component level, the
code to reset dependent fields was no longer properly 'generic' and the
approach with a prefix was not the most elegant:

* it assumes the other (dependent) field names are the same in
  registration and prefill (they are, but deliberately, though there's
  no guarantee they will be in the future)
* it assumes a certain structure, but dependent fields may live in
  another namespace or the reset behaviour could require additional
  changes in the form state to be made

Instead, the reset behaviour can now be passed in as a prop, so that
the caller/user of the ObjectsAPIGroup component is in control of
which state exactly gets reset.

This already reflects nicely since the variableMapping reset in the
Legacy Objects API registration configuration didn't make any sense,
it's a V2 option, so now we have tailored reset functions to the
expected data structure.
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
🎨 [#4608] Fine tune ObjectTypeSelect refactor
b87f662 
Renamed and documented the props for more consistency with the rest of
the codebase.
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
🎨 [#4608] Fine tune ObjectTypeVersionSelect refactor
1f3b42e 
Renamed and documented the props for more consistency with the rest of
the codebase.
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
🚚 [#4608] Split 'default' prefill fields to separate files
5fc46a3 
Once we start re-using bits and pieces and have plugin-specific code/
configuration, it's better to stick to the one-component-per-file
approach since (some of) the components are now re-usable and semi-
public API.
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
🚚 [#4608] Move objects API specific configuration to own file
4aac832
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
♻️ [#4608] Ensure that plugin dropdown is part of core form
d31b31b 
This way, plugin-specific configuration forms cannot accidentally make
it impossible to change the plugin type again when a mistake is made,
and it reduces the code repetition.
sergei-maertens added a commit that referenced this issue Oct 8, 2024
@sergei-maertens
Merge pull request #4610 from open-formulieren/feature/4608-product-p…
3a310db 
…refill-modal

✨ [#4608] Modal for Objects API prefill options
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 8, 2024
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@stevenbal @robinmolen
✨ [#4608] Modal for Objects API prefill options
98a1287 
this is the initial implementation, it is not yet fully functional, since it relies on backend changes that are not merged yet.
It will be connected with the backend in #4693
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@stevenbal @robinmolen
🌐 [#4608] Update JS translation assets
add4af7
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@stevenbal @robinmolen
👌 [#4608] PR feedback
3ff6509 
* make VariableMapping generic by moving it outside of DMN directory
* rename extraData to configurationContext
* add test for plugin configurationContext
* rename prefillAttribute to prefillProperty for Objects API prefill
* move VariableMapping styling to its own file
* define mapping for prefill plugins to components
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@stevenbal @robinmolen
✅ [#4608] Add storybook story for VariableMapping
cae82bd
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@stevenbal @robinmolen
♻️ [#4608] Ensure objects API prefill uses lists for prefillProperties
685ea77 
because the prefill properties endpoint also specifies `targetPath`, which are lists to distinguish between nested values and values with `.` in  them.

Also ensure alreadyMapped works for Objects API prefill mapping
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@stevenbal @robinmolen
🚚 [#4608] Move Objects API admin fields to generic location
87477ee 
previously these were defined as part of registrations, but since they are now also used by prefill, their location should reflect that they are generic

* ObjectsAPIGroup
* ObjectTypeSelect
* ObjectTypeVersionSelect
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@stevenbal @robinmolen
🌐 [#4608] Update JS translation assets
ce8c790
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🎨 [#4608] Clean up API of VariableMapping component
21ba96e
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
♻️ [#4608] Update DMN config form to use VariableMapping component
7cb3153 
Now the VariableMapping component interface is determined, we need
to make sure that the DMN configuration form can still properly
use it after making it more generic.
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
♻️ [#4608] Refactor updated VariableMapping interface in prefill modal
2e521d5 
After changing the API of the VariableMapping, the tests and implementation
in the prefill configuration modal needed to be updated to be compatible.
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🎨 [#4608] Import model from the correct place
4e9554e
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🚸 [#4608] Add arrows to indicate mapping direction
f3bd58f 
Since there are two columns for source/target in the variable mapping
component, it makes sense to display the direction of assignment
with an arrow.
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🚚 [#4608] Move useSynchronizeSelect to shared forms package
b170fee 
The hook is actually more broadly usable than in the objects_api, but
for the time being it's only used there.
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🎨 [#4608] Finetune ObjectsAPIGroup refactor
5acf3ee 
After moving the ObjectsAPIGroup component to a shared field layer
where the form data structure is unknown at the component level, the
code to reset dependent fields was no longer properly 'generic' and the
approach with a prefix was not the most elegant:

* it assumes the other (dependent) field names are the same in
  registration and prefill (they are, but deliberately, though there's
  no guarantee they will be in the future)
* it assumes a certain structure, but dependent fields may live in
  another namespace or the reset behaviour could require additional
  changes in the form state to be made

Instead, the reset behaviour can now be passed in as a prop, so that
the caller/user of the ObjectsAPIGroup component is in control of
which state exactly gets reset.

This already reflects nicely since the variableMapping reset in the
Legacy Objects API registration configuration didn't make any sense,
it's a V2 option, so now we have tailored reset functions to the
expected data structure.
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🎨 [#4608] Fine tune ObjectTypeSelect refactor
e457eec 
Renamed and documented the props for more consistency with the rest of
the codebase.
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🎨 [#4608] Fine tune ObjectTypeVersionSelect refactor
5743238 
Renamed and documented the props for more consistency with the rest of
the codebase.
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🚚 [#4608] Split 'default' prefill fields to separate files
ab50e32 
Once we start re-using bits and pieces and have plugin-specific code/
configuration, it's better to stick to the one-component-per-file
approach since (some of) the components are now re-usable and semi-
public API.
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
🚚 [#4608] Move objects API specific configuration to own file
4e95899
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
♻️ [#4608] Ensure that plugin dropdown is part of core form
a85cb9d 
This way, plugin-specific configuration forms cannot accidentally make
it impossible to change the plugin type again when a mistake is made,
and it reduces the code repetition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
enhancement owner: den-haag
Projects
Development
Archived in project
Milestone
Release 3.0
Development

Successfully merging a pull request may close this issue.

✨ [#4608] Modal for Objects API prefill options open-formulieren/open-forms
1 participant
@stevenbal