Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove display code from targetclid #169

Open
iammattcoleman opened this issue Apr 8, 2020 · 1 comment
Open

remove display code from targetclid #169

iammattcoleman opened this issue Apr 8, 2020 · 1 comment

Comments

@iammattcoleman
Copy link
Contributor

iammattcoleman commented Apr 8, 2020

Currently, the daemon is accepting raw command line parameters and returning formatted terminal output. As discussed in several pull requests, this results in several differences in targetcli's behavior when it's not using the daemon vs. when it is. The code's complexity is also increasing due to a lack of separation of concerns.

I propose changing targetclid to export its functionality via some form of IPC/RPC: when auto_use_daemon is set to True, targetcli would receive input, pass requests to targetclid (which would do the actual work and respond with structured data), and then format and display the response data.

This ticket should be used to discuss implementation details such as which form of IPC/RPC to use.

@iammattcoleman
Copy link
Contributor Author

I think dbus makes the most sense, since it's already standard in most distributions and used by many core system services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant