Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18678: Remove ORDER BY from the postgres DELETE statement #18757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #18678: Remove ORDER BY from the postgres DELETE statement #18757

wants to merge 1 commit into from
+1 −1

Conversation

mramirsha
Copy link

@mramirsha mramirsha commented Nov 24, 2024 •
edited
Loading

Describe your changes:

Removing ORDER BY clause in Postgresql delete statement.
Fixes #18678

The following api used in ingestion pipelines and when the lineage override feature has been enabled, the pipeline will throw the following error:

Caused by: org.postgresql.util.PSQLException: ERROR: syntax error at or near "ORDER"

Root cause: Calling the following endpoint will throw a syntax error:

curl -X DELETE -H "Authorization: Bearer token" -H "Accept: application/json" https://localhost/api/v1/lineage/pipeline/cb6fe35c-5cb4-4ff8-9e68-ee50229e3bdf/type/PipelineLineage

There is no ORDER BY clause in Postgresql DELETE statement. Docs

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mramirsha mramirsha requested a review from a team as a code owner November 24, 2024 12:12
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Nov 24, 2024
@harshach
Copy link
Collaborator

Thanks for the contribution @mramirsha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Airflow override lineage option is not working properly
2 participants
@mramirsha @harshach