Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in positional_encoding.py #324

Open
AnikinNN opened this issue Jun 29, 2022 · 1 comment
Open

Typo in positional_encoding.py #324

AnikinNN opened this issue Jun 29, 2022 · 1 comment
Assignees
@plyfager
Labels
kind/bug something isn't working priority/P0 highest priority status/WIP work in progress normally
Milestone
0.8.0

Comments

@AnikinNN
Copy link

Tere is a class CatersianGrid in /mmgen/models/architectures/positional_encoding.py
It seems that there is a typo CatersianGrid -> CartesianGrid
@plyfager
Copy link
Collaborator

plyfager commented Jul 5, 2022 •
edited
Loading

Thanks for your remind. We will appreciate it a lot if you'd like to make a PR to fix this typo.

@zengyh1900 zengyh1900 added kind/bug something isn't working awaiting response priority/P0 highest priority labels Oct 12, 2022
@zengyh1900 zengyh1900 added this to the 0.8.0 milestone Oct 12, 2022
@plyfager plyfager added status/WIP work in progress normally and removed awaiting response labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plyfager plyfager

Labels
kind/bug something isn't working priority/P0 highest priority status/WIP work in progress normally
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@zengyh1900 @plyfager @AnikinNN