Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update UI for card component #242

Closed
wants to merge 1 commit into from

Conversation

Codexnever
Copy link
Contributor

Description

This PR fixes the button positioning in the card components for better visual consistency. The position of the "Start the Intro to Open Source Course" and "Start the Becoming a Maintainer Course" buttons has been adjusted to enhance the overall UI layout.

Changes Made:

  • Adjusted the CSS styling of .cardContent and .cardLink to ensure the buttons are aligned consistently at the bottom of each card, improving the appearance of both cards.
  • Ensured that the button spacing accommodates varying content lengths between the two cards.

Before Changes:

  • The button in the "Becoming a Maintainer" card appeared higher than the button in the "Intro to Open Source Course" card due to less content in that card.

Before

After Changes:

  • Both buttons now align uniformly at the bottom of their respective cards, providing a balanced and visually appealing layout.

After

Steps to QA

  1. Navigate to the page containing the card components.
  2. Verify that the "Start the Intro to Open Source Course" and "Start the Becoming a Maintainer Course" buttons are positioned at the bottom of their respective cards.
  3. Check that the cards maintain a consistent appearance across different screen sizes.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

@Codexnever Codexnever requested a review from a team as a code owner October 1, 2024 10:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • package-lock.json

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for learn-opensauced ready!

Name Link
🔨 Latest commit 337eaf5
🔍 Latest deploy log https://app.netlify.com/sites/learn-opensauced/deploys/66fbd4840596b50008d21cb7
😎 Deploy Preview https://deploy-preview-242--learn-opensauced.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@adiati98
Copy link
Member

adiati98 commented Oct 1, 2024

Hey @Codexnever,
Because there is no issue accompanying this PR, unfortunately we have to close it. See this section in our contributing guidelines.

Please read our contributing guidelines carefully before you contribute to our repositories.

That said, you can submit an issue, and our team will triage it. Thank you. 🙂

@adiati98 adiati98 closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants