Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add image of completed PR template for Guestbook #244

Closed
BekahHW opened this issue Oct 3, 2024 · 2 comments · Fixed by #245
Closed

Feature: Add image of completed PR template for Guestbook #244

BekahHW opened this issue Oct 3, 2024 · 2 comments · Fixed by #245
Assignees

Comments

@BekahHW
Copy link
Member

BekahHW commented Oct 3, 2024

Suggested solution

One of the things we see a lot when reviewing the guestbook PRs is the PR form isn't filled out properly.

In the Getting Started Section of the Practical Application let's add a screenshot below the warning after the text of 11.

Here's what a completed Pull Request Template for the guestbook looks like. Make sure yours looks like this, with your unique information.

image
@pedaars
Copy link
Contributor

pedaars commented Oct 3, 2024

.take
@BekahHW happy to pick this issue up

@BekahHW
Copy link
Member Author

BekahHW commented Oct 3, 2024

Thanks! @pedaars please take a look at our contributing guidelines to assign yourself the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants