Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context through persistent queue #11740

Open
Tracked by #8804
mackjmr opened this issue Nov 25, 2024 · 0 comments
Open
Tracked by #8804

Context through persistent queue #11740

mackjmr opened this issue Nov 25, 2024 · 0 comments

Comments

@mackjmr
Copy link
Member

mackjmr commented Nov 25, 2024

Is your feature request related to a problem? Please describe.
Currently, context gets lost when persistant queue is used. The context gets lost in the call to Batch. Batch is an interface, and is implemented by the storage system. For filestorage, the call to Batch does not use the context at all.

This poses issues for #8804. One of the proposed solutions is to instrument the consumer. Because of the above, the context will be lost between the consumer span and the export span. See the following comment: #8804 (comment) for a more detailed view of the issue

Describe the solution you'd like
Keep track of context (or at least trace ID) across persistant queue. If internal instrumentation is the only use case, we could add the trace_id to the info we put in the queue. At the time the queue is read, we can use the trace ID to link both spans (span link, or parent/child).

@mx-psi mx-psi changed the title Context through persistant queue Context through persistent queue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant