From b6909af0782dec0f8f259ccb29f864627f162f87 Mon Sep 17 00:00:00 2001
From: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Date: Thu, 28 Sep 2023 22:45:15 -0700
Subject: [PATCH] validate double value

---
 sdk/src/metrics/sync_instruments.cc | 79 ++++++++++++++++++++++++++++-
 1 file changed, 77 insertions(+), 2 deletions(-)

diff --git a/sdk/src/metrics/sync_instruments.cc b/sdk/src/metrics/sync_instruments.cc
index ece2a094b9..657571dc3d 100644
--- a/sdk/src/metrics/sync_instruments.cc
+++ b/sdk/src/metrics/sync_instruments.cc
@@ -85,13 +85,19 @@ DoubleCounter::DoubleCounter(InstrumentDescriptor instrument_descriptor,
 void DoubleCounter::Add(double value,
                         const opentelemetry::common::KeyValueIterable &attributes) noexcept
 {
-  auto context = opentelemetry::context::Context{};
+  if (double < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleCounter::Add(V,A)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleCounter::Add(V,A)] Value not recorded - invalid storage for: "
                            << instrument_descriptor_.name_);
     return;
   }
+  auto context = opentelemetry::context::Context{};
   return storage_->RecordDouble(value, attributes, context);
 }
 
@@ -99,6 +105,12 @@ void DoubleCounter::Add(double value,
                         const opentelemetry::common::KeyValueIterable &attributes,
                         const opentelemetry::context::Context &context) noexcept
 {
+  if (double < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleCounter::Add(V,A,C)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleCounter::Add(V,A,C)] Value not recorded - invalid storage for: "
@@ -110,18 +122,30 @@ void DoubleCounter::Add(double value,
 
 void DoubleCounter::Add(double value) noexcept
 {
-  auto context = opentelemetry::context::Context{};
+  if (double < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleCounter::Add(V)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleCounter::Add(V)] Value not recorded - invalid storage for: "
                            << instrument_descriptor_.name_);
     return;
   }
+  auto context = opentelemetry::context::Context{};
   return storage_->RecordDouble(value, context);
 }
 
 void DoubleCounter::Add(double value, const opentelemetry::context::Context &context) noexcept
 {
+  if (double < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleCounter::Add(V)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleCounter::Add(V,C)] Value not recorded - invalid storage for: "
@@ -338,6 +362,13 @@ void DoubleHistogram::Record(double value,
                              const opentelemetry::common::KeyValueIterable &attributes,
                              const opentelemetry::context::Context &context) noexcept
 {
+  if (value < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN(
+        "[DoubleHistogram::Record(V,A,C)] Value not recorded - negative value for: "
+        << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN(
@@ -350,6 +381,13 @@ void DoubleHistogram::Record(double value,
 
 void DoubleHistogram::Record(double value, const opentelemetry::context::Context &context) noexcept
 {
+  if (value < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN(
+        "[DoubleHistogram::Record(V,C)] Value not recorded - negative value for: "
+        << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN(
@@ -364,6 +402,13 @@ void DoubleHistogram::Record(double value, const opentelemetry::context::Context
 void DoubleHistogram::Record(double value,
                              const opentelemetry::common::KeyValueIterable &attributes) noexcept
 {
+  if (value < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN(
+        "[DoubleHistogram::Record(V,A)] Value not recorded - negative value for: "
+        << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN(
@@ -377,6 +422,12 @@ void DoubleHistogram::Record(double value,
 
 void DoubleHistogram::Record(double value) noexcept
 {
+  if (value < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleHistogram::Record(V)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleHistogram::Record(V)] Value not recorded - invalid storage for: "
@@ -466,6 +517,12 @@ void DoubleGauge::Record(double value,
                          const opentelemetry::common::KeyValueIterable &attributes,
                          const opentelemetry::context::Context &context) noexcept
 {
+  if (value < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleGauge::Record(V,A,C)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleGauge::Record(V,A,C)] Value not recorded - invalid storage for: "
@@ -477,6 +534,12 @@ void DoubleGauge::Record(double value,
 
 void DoubleGauge::Record(double value, const opentelemetry::context::Context &context) noexcept
 {
+  if (value < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleGauge::Record(V,C)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleGauge::Record(V,C)] Value not recorded - invalid storage for: "
@@ -489,6 +552,12 @@ void DoubleGauge::Record(double value, const opentelemetry::context::Context &co
 void DoubleGauge::Record(double value,
                          const opentelemetry::common::KeyValueIterable &attributes) noexcept
 {
+  if (value < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleGauge::Record(V,A)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleGauge::Record(V,A)] Value not recorded - invalid storage for: "
@@ -501,6 +570,12 @@ void DoubleGauge::Record(double value,
 
 void DoubleGauge::Record(double value) noexcept
 {
+  if (value < 0)
+  {
+    OTEL_INTERNAL_LOG_WARN("[DoubleGauge::Record(V)] Value not recorded - negative value for: "
+                           << instrument_descriptor_.name_);
+    return;
+  }
   if (!storage_)
   {
     OTEL_INTERNAL_LOG_WARN("[DoubleGauge::Record(V)] Value not recorded - invalid storage for: "