Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Synchronous Gauge instrument to the metrics API/SDK #2279

Closed
fgallegosalido opened this issue Aug 25, 2023 · 5 comments · Fixed by #3029
Closed

Add Synchronous Gauge instrument to the metrics API/SDK #2279

fgallegosalido opened this issue Aug 25, 2023 · 5 comments · Fixed by #3029
Labels
breaking change API or ABI breaking change do-not-stale help wanted Good for taking. Extra help will be provided by maintainers Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fgallegosalido
Copy link

Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue on opentelemetry-specification first.

Is your feature request related to a problem?
There's plenty of use cases described in the specification issue.

Describe the solution you'd like
I expect to have two new functions in the class Meter called CreateInt64Gauge() and CreateDoubleGauge() along with the template class Gauge. They should behave like the ObservableGauge instrument, but being synchronous instead of asynchronous.

Describe alternatives you've considered
This is described as an experimental feature in the OpenTelemetry specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#gauge

Additional context
Add any other context about the feature request here.

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 25, 2023
@lalitb
Copy link
Member

lalitb commented Aug 25, 2023

Thanks for creating the issue. Adding for reference the relevant Specs PR -
open-telemetry/opentelemetry-specification#3540

@marcalff
Copy link
Member

So:

  • this is a recent addition in the spec,
  • the meter API is impacted, as it needs a new virtual method,
  • this makes it an ABI breaking change for C++.

We really need a plan to handle ABI changes gracefully, see #2222

@marcalff marcalff added the breaking change API or ABI breaking change label Aug 25, 2023
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 1, 2023
@marcalff marcalff assigned lalitb and unassigned marcalff Sep 20, 2023
@marcalff
Copy link
Member

Depends on:

which will add CI for a WITH_ABI_VERSION_2 build.

@lalitb lalitb mentioned this issue Sep 29, 2023
3 tasks
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Nov 20, 2023
@lalitb lalitb removed their assignment Aug 2, 2024
@lalitb lalitb added the help wanted Good for taking. Extra help will be provided by maintainers label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

This issue is available for anyone to work on. Make sure to reference this issue in your pull request.
✨ Thank you for your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change API or ABI breaking change do-not-stale help wanted Good for taking. Extra help will be provided by maintainers Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
4 participants