Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exemplar is missing in async_metric_storage #2318

Closed
ThomsonTan opened this issue Sep 19, 2023 · 0 comments · Fixed by #2319
Closed

Exemplar is missing in async_metric_storage #2318

ThomsonTan opened this issue Sep 19, 2023 · 0 comments · Fixed by #2319
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ThomsonTan
Copy link
Contributor

As async instrument was added after the exemplar support, it also missed the exemplar support in https://github.com/open-telemetry/opentelemetry-cpp/blob/main/sdk/include/opentelemetry/sdk/metrics/state/async_metric_storage.h.
@ThomsonTan ThomsonTan added the bug Something isn't working label Sep 19, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 19, 2023
@ThomsonTan ThomsonTan mentioned this issue Sep 19, 2023
Merged
3 tasks
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK] Add exemplar reservoir to async metric storage ThomsonTan/opentelemetry-cpp
2 participants
@ThomsonTan @marcalff