Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetLogger doesn't return the expected logger if empty library name is in the arguments #2397

Closed
ThomsonTan opened this issue Nov 10, 2023 · 0 comments · Fixed by #2398
Closed
Labels
bug Something isn't working

Comments

@ThomsonTan
Copy link
Contributor

The below test currently fails, because when creating new Logger, library_name in InstrumentationScope is set to logger_name if the passed in library_name is empty, but this logic is not honored when doing equity test between loggers.

auto lp1 = Provider::GetLoggerProvider()->GetLogger("Logger1");
auto another_lp1 = Provider::GetLoggerProvider()->GetLogger("Logger1");

EXPECT_EQ(lp1, another_lp1);
@ThomsonTan ThomsonTan added the bug Something isn't working label Nov 10, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 10, 2023
@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants