-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Create a feature for OTel ABI 2.0 in vcpkg #2448
Comments
Accepting the issue in opentelemetry-cpp as a place holder. Fix to be implemented in the vcpkg repository. |
Unfortunately, this behaviour is disallowed by the manifests vcpkg docs/spec:
It is a shame, really - I'd like to be able to enable WITH_STL in the vcpkg build. The solution is to create a custom port, which is the port in the official vcpkg repository slightly modified (add otel abi 2.0, with_stl etc.). This is what I do. -- I'd love it if an "official" vcpkg registry existed in open-telemetry/opentelemetry-cpp-vcpkg-registry. This could contain different variants of optentelemetry-cpp as ports (opentelemetry-cpp-stl, opentelemetry-abi2, ... ). |
Agh, that's unfortunate. Thanks for letting me know @meastp. I think I'm gonna end up building from source for CI, but thanks for mentioning the solution (maybe it will help someone else). Maintainers, feel free to close or change the issue as you see fit. |
@alevenberg You could try to update the vcpkg-repo's port to use abi v2. imho, newest abi should be the default. I can look into making changes + PR there if @ThomsonTan @latlib @marcalff ... agree? Also, there are alternatives to making a custom registry. If you make a ports folder in your project repo (or anywhere, really) and use environment variable --https://learn.microsoft.com/en-us/vcpkg/users/config-environment#vcpkg_overlay_ports |
Thanks for the offer, but no, please don't. ABI v2 is unstable, and will change, as there are many things to cleanup, refactor, and improve there. Exposing an unstable interface can only create more trouble for users, and maintainers as well when dealing with a new flow of bug reports related to breaking changes. One user testing ABI v2 as an early adopter is fine, even welcomed, but forcing everyone to use ABI v2 by default is another matter. By the time ABI v2 is published as stable, this can of course be revised. |
@marcalff no worries :) |
This issue was marked as stale due to lack of activity. |
We build OTel in our CI and want to add a build with cmake and otel abi 2.0. We use vcpkg as a package manager.
My ideal vcpkg.json would look like
Is your feature request related to a problem?
No
Describe the solution you'd like
The current vcpkg does not have an otel abi feature (https://github.com/microsoft/vcpkg/blob/42301df395852935d105799de93abf5481f34f1a/ports/opentelemetry-cpp/vcpkg.json)
Describe alternatives you've considered
Building from source.
Additional context
N/A
The text was updated successfully, but these errors were encountered: