Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpentTelemetry-Cpp vcpkg package includes gRPC and Protobuf when configured with the otlp-http option. #2536

Closed
LarryOsterman opened this issue Feb 15, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@LarryOsterman
Copy link

Describe your environment

Installing opentelemetry-cpp using the vcpkg package management system, specifying the "otlp-http" feature.

Steps to reproduce

Configure OpenTelemetry specifying the otlp-http feature:

    {
      "name": "opentelemetry-cpp",
      "features": ["otlp-http"],
      "platform": "!(windows & !static)",
      "version>=": "1.3.0"
    },

What is the expected behavior?
OpenTelemetry otlp exporter in installed with no additional dependencies beyond curl.

What is the actual behavior?
OpenTelemetry is installed with:

 vcpkg depend-info  opentelemetry-cpp[otlp-http]
warning: In the September 2023 release, the default triplet for vcpkg libraries changed from x86-windows to the detected host triplet (x64-windows). For the old behavior, add --triplet x86-windows . To suppress this message, add --triplet x64-windows .
Fetching registry information from https://github.com/microsoft/vcpkg (HEAD)...
vcpkg-cmake:
vcpkg-cmake-config:
abseil: vcpkg-cmake, vcpkg-cmake-config
protobuf: vcpkg-cmake, vcpkg-cmake-config
vcpkg-cmake-get-vars: vcpkg-cmake
c-ares: vcpkg-cmake, vcpkg-cmake-config
openssl: vcpkg-cmake, vcpkg-cmake-config, vcpkg-cmake-get-vars
re2: abseil, vcpkg-cmake, vcpkg-cmake-config
upb[codegen]: abseil, protobuf, vcpkg-cmake, vcpkg-cmake-config
zlib: vcpkg-cmake
curl[non-http, ssl, schannel, sspi]: vcpkg-cmake, vcpkg-cmake-config, zlib
grpc[codegen]: abseil, c-ares, openssl, protobuf, re2, upb, vcpkg-cmake, vcpkg-cmake-config, zlib
nlohmann-json: vcpkg-cmake, vcpkg-cmake-config
opentelemetry-cpp[otlp, otlp-http, otlp-grpc]: abseil, curl, grpc, nlohmann-json, vcpkg-cmake, vcpkg-cmake-config

There should be no reason for protobuf or grpc when configuring the http feature.

@LarryOsterman LarryOsterman added the bug Something isn't working label Feb 15, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 15, 2024
@ThomsonTan
Copy link
Contributor

@LarryOsterman thanks for reporting this.

Which version of vcpkg are you using? The gRPC dependence has been removed from otlp-http feature in some recent vcpkg ports improvement.

https://github.com/microsoft/vcpkg/blob/a56d892ac792797d779eae79d3423e0131422628/ports/opentelemetry-cpp/vcpkg.json#L47

@ThomsonTan ThomsonTan self-assigned this Feb 15, 2024
@LarryOsterman
Copy link
Author

LarryOsterman commented Feb 20, 2024

@#$ - The baseline commit in my fork is 43cf47eccfbe27006cf9534a5db809798f8c37fe, which is from November of 2023. We updated our baseline last week and if I'd been up to date, it would have been fixed.

Sorry for that.

@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants