Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::variant documentation is not clear enough #2539

Open
orion160 opened this issue Feb 18, 2024 · 5 comments
Open

::variant documentation is not clear enough #2539

orion160 opened this issue Feb 18, 2024 · 5 comments
Labels
bug Something isn't working help wanted Good for taking. Extra help will be provided by maintainers Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@orion160
Copy link
Contributor

Uses Abseil C++ Library for absl::variant as default nostd::variant if WITH_ABSEIL cmake option or --@io_opentelemetry_cpp//api:with_abseil=true (aka --//api:with_abseil=true) bazel option is enabled. License: Apache License 2.0

https://github.com/open-telemetry/opentelemetry-cpp/blob/main/docs/dependencies.md

@orion160 orion160 added the bug Something isn't working label Feb 18, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 18, 2024
@orion160
Copy link
Contributor Author

Key points:

WITH_ABSEIL uses nostd::variant or absl::variant?

Are WITH_STL and WITH_ABSL exclusive?

@ThomsonTan ThomsonTan added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Good for taking. Extra help will be provided by maintainers and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 21, 2024
Copy link

This issue is available for anyone to work on. Make sure to reference this issue in your pull request.
✨ Thank you for your contribution! ✨

Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Apr 23, 2024
@Annosha
Copy link

Annosha commented Oct 17, 2024

Hi @orion160, is this issue beginner friendly? I don't have a very deep understanding of C++ but would like to contribute if it isn't very complex to work on. TIA

@github-actions github-actions bot removed the Stale label Oct 20, 2024
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Good for taking. Extra help will be provided by maintainers Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants