Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC version prompt #3057

Closed
michaelchao opened this issue Sep 9, 2024 · 4 comments
Closed

gRPC version prompt #3057

michaelchao opened this issue Sep 9, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@michaelchao
Copy link

I'm now using otel-cpp with gRPC, however compile failed, I don't now what version of gRPC should I use. SI I recommend adding version required infomation for gRPC in README.

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 9, 2024
@owent
Copy link
Member

owent commented Sep 10, 2024

We support many versions of gRPC, which one to use depends on your build system.
If you do not use gRPC before, here is a recommend versions of depended packages: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/third_party_release

@marcalff
Copy link
Member

As @owent described:

  • opentelemetry-cpp does not require a specific version of grpc. Instead, the model is that opentelemetry-cpp uses the version of grpc that might be already used by the application, due to other dependencies.
  • If there are no reasons to use a specific version, a good choice is to pick the version used in CI tests. Currently, this is gRPC=v1.49.2, per the third_party_release file.

Accepting this report as a documentation issue, so that the README or related doc mention clearly where to find the current information for each dependency.

@marcalff marcalff added documentation Improvements or additions to documentation triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 23, 2024
@michaelchao
Copy link
Author

Tks all suggestions

@michaelchao
Copy link
Author

Ths, done

@michaelchao michaelchao reopened this Oct 8, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 8, 2024
@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants