Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus Exporter: otel_scope attributes not present by default #3170

Closed
yashykt opened this issue Nov 26, 2024 · 0 comments · Fixed by #3171
Closed

Prometheus Exporter: otel_scope attributes not present by default #3170

yashykt opened this issue Nov 26, 2024 · 0 comments · Fixed by #3171
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@yashykt
Copy link
Contributor

yashykt commented Nov 26, 2024

I noticed that #2479 changed the default from otel_scope attributes being populated to being off by default. From my reading of the code, it seems like this was an oversight.
@yashykt yashykt added the bug Something isn't working label Nov 26, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 26, 2024
@yashykt yashykt mentioned this issue Nov 26, 2024
Merged
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PROMETHEUS_EXPORTER] Fix default for emitting otel_scope attributes yashykt/opentelemetry-cpp
2 participants
@yashykt @marcalff