Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP Client] Reduce the frequency of creating and destroying background threads in HTTP Client. #3189

Closed
owent opened this issue Dec 5, 2024 · 0 comments · Fixed by #3198
Closed

[HTTP Client] Reduce the frequency of creating and destroying background threads in HTTP Client. #3189

owent opened this issue Dec 5, 2024 · 0 comments · Fixed by #3198
Assignees
@owent
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@owent
Copy link
Member

owent commented Dec 5, 2024

Is your feature request related to a problem?
The HTTP Client may frequently create and destroy threads when it's not always busy, which will cost a lot of resource.
Could we keep the background thread for a while and destroy only when it's free for some more time? Just like the background thread in OTLP file exporter.

I can take this, if it's accepted.

Describe the solution you'd like
Wait a longer time to destroy HTTP Client's background thread.

Additional context
I can casually try to optimize the issue in #3172.
@owent owent self-assigned this Dec 5, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 5, 2024
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 5, 2024
@xiehuc xiehuc mentioned this issue Dec 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owent owent

Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK] Do not frequently create and destroy http client threads xiehuc/opentelemetry-cpp
2 participants
@owent @marcalff