Try to fix lifetime of GlobalLogHandler #3221
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
- Coverage 88.16% 88.15% -0.00%
==========================================
Files 198 198
Lines 6224 6236 +12
==========================================
+ Hits 5487 5497 +10
- Misses 737 739 +2
|
| { | ||
| return GetHandlerAndLevel().first; | ||
| if OPENTELEMETRY_UNLIKELY_CONDITION (GetHandlerAndLevel().destroyed) |
There was a problem hiding this comment.
If I interpret the standard correctly, this may be an undefined behavior.
[basic.life] says that "[t]he lifetime of an object o of type T ends when: <...> if T is a class type, the destructor call starts", and "after the lifetime of an object has ended and before the storage which the object occupied is reused or released, any pointer that represents the address of the storage location where the object will be or was located may be used but only in limited ways. <...> The program has undefined behavior if: <...> the pointer is used to access a non-static data member or call a non-static member function of the object".
There was a problem hiding this comment.
Yes, it's a trick that the memory address of a static local variable will always be available in practice. So we can visit it even if it's destructed.
Fixes #3215
Changes
GlobalLogHandlerwhen callingOTEL_INTERNAL_LOG_*.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes