[SDK] Add exemplar reservoir to async metric storage #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2319 +/- ##
==========================================
+ Coverage 87.45% 87.47% +0.02%
==========================================
Files 199 199
Lines 5996 5997 +1
==========================================
+ Hits 5243 5245 +2
+ Misses 753 752 -1
|
marcalff
approved these changes
Sep 21, 2023
Comment on lines
+56
to
+59
| #ifdef ENABLE_METRICS_EXEMPLAR_PREVIEW | ||
| exemplar_reservoir_->OfferMeasurement(measurement.second, {}, {}, | ||
| std::chrono::system_clock::now()); | ||
| #endif |
There was a problem hiding this comment.
This makes the async code at par with the sync metric storage, so approved.
In the long term, I think we will need to refactor the exemplar reservoir interface, to reduce overhead.
This calls:
- creates dummy objects, for each measurements
- calls now(), for each measurement
- invoke a virtual function
- only to land on a noop implementation in common cases
Very wasteful compared to representing a noop reservoir with a nullptr, and testing a pointer.
Ok as long as we have a feature flag.
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2318
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes